jextract/jni: handle tuples with array elements#685
Merged
ktoso merged 3 commits intoswiftlang:mainfrom Apr 8, 2026
Merged
Conversation
We'd wrongly render the array used for the tuple out parameter and the dimension of the elements would be at the end of the type, but it must be [3][][][] rather than [][][]][3]. This allows returning arrays inside tuples
ktoso
commented
Apr 8, 2026
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Outdated
Show resolved
Hide resolved
generating code which assumed this was correct huh
ktoso
force-pushed
the
wip-tuple-of-arrays
branch
from
0a1919c to
e2cfe98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd wrongly render the array used for the tuple out parameter and the dimension of the elements would be at the end of the type, but it must be [3][][][] rather than [][][][3].
This allows returning arrays inside tuples