Rework the cleanup a little bit so that we avoid the atomic boolean #761
Merged
Merged
Conversation
The atomic boolean was one extra heap allocation which we now avoid -- we just create one cleanup and inside it have an int, rather than creating the Bool separately and passing it to the cleanup. AFAICS this will avoid one alloc, which isn't much, but can add up since we do it for every wrapped swift object. This keeps semantics added by @sidepelican in swiftlang#760 just avoids the one heap alloc per SwiftInstance
ktoso
commented
May 20, 2026
| private final long selfPointer; | ||
|
|
||
| /** Used to track additional state of the underlying object, e.g. if it was explicitly destroyed. */ | ||
| private final AtomicBoolean $state$destroyed = new AtomicBoolean(false); |
Collaborator
Author
There was a problem hiding this comment.
The alloc we're removing; instead we have the Cleanup as we did before; alloc it early, but then inside the Cleanup we have no other heap objects -- just the int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atomic boolean was one extra heap allocation which we now avoid --
we just create one cleanup and inside it have an int, rather than
creating the Bool separately and passing it to the cleanup. AFAICS this
will avoid one alloc, which isn't much, but can add up since we do it
for every wrapped swift object.
This keeps semantics added by @sidepelican in #760 just avoids the one heap alloc per SwiftInstance