Fix #238 out of bounds crash when formatting tables #250
+56
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: #238
Summary
If a table included multiple pipe characters that took the total number of columns (including spanning columns) above the main column count, this would cause a crash instead of just dropping the excess content as per the spec.
This PR removes the attempted out-of-bounds read of the widths array by capping the count.
Dependencies
None
Testing
Two unit tests have been added to exercise the code. To manually test it, you can attempt to parse markdown like this:
And then
formatthe resulting document, which will crash without these changes in place.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded