Skip to content

Conversation

@RobinBateman808
Copy link
Contributor

@RobinBateman808 RobinBateman808 commented Mar 20, 2024

Motivation:

Documentation isn't formatting correctly, potentially confusing user instructions and examples.

Modifications:

Corrected syntax and adjusted spacing.

Result:

Correct formatting and flow of information.

@RobinBateman808
Copy link
Contributor Author

@0xTim - Here's the corrected PR. Apologies for the other and causing any confusion. No content changes were made, only syntax to correct the flow of information on the page.

}
myFunctionDoingTheAllocation()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these linebreaks at the bottom of the codeblocks required (the ones inside as opposed to outside) - doesn't that just add an extra line to all code blocks?

Copy link
Contributor Author

@RobinBateman808 RobinBateman808 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I reverted the syntax (the extra spaces were initially there). I also removed characters that I suspect threw the formatting off and bolded "Notes" and "Tips". I tightened up the extra spaces yesterday, but the GitHub "preview" isn't always rendering how it actually displays on the published web page. So, hoping these changes will take care of it so no further changes are needed. My apologies for the extra cycle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobinBateman808 I removed the extra line breaks at the bottom of the code blocks as they were adding extra whitespace and weren't needed. You should be able to run the website locally following the README instructions - just checked and it's rendering fine now

@RobinBateman808 RobinBateman808 changed the title Reformatted doc syntax to correct flow Reformatted debug mem leak doc Mar 20, 2024
RobinBateman808 and others added 2 commits March 20, 2024 16:21
Removed spacing for a numbered bullet set to remove formatting as a code block.
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim enabled auto-merge (squash) March 23, 2024 03:14
@0xTim
Copy link
Member

0xTim commented Mar 23, 2024

@swift-ci please test

@0xTim 0xTim merged commit 74caef9 into main Mar 23, 2024
@0xTim 0xTim deleted the reformat-debug-mem-leaks branch March 23, 2024 03:15
cthielen pushed a commit to Joannis/swift-org-website that referenced this pull request Mar 26, 2024
* Reformatted and added spaces before backticks to correct content alignment.

* Update memory-leaks-and-usage.md

Removed spacing for a numbered bullet set to remove formatting as a code block.

* Tidy up code formats

---------

Co-authored-by: Tim <0xtimc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants