Refactor/versioning #3237
Merged
Refactor/versioning #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: the logic in Versioning does not belong in TSC, its a SwiftPM concern changes: * move Versioning/SwiftVersion to Basics module * move Git::convertTagsToVersionMap to its only callsite * adjust callsites
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
neonichu
approved these changes
Feb 5, 2021
Contributor
Author
|
related TSC PR: swiftlang/swift-tools-support-core#188 |
abertelrud
approved these changes
Feb 6, 2021
Contributor
abertelrud
left a comment
abertelrud
left a comment
There was a problem hiding this comment.
This is great; thank you for dealing with this! Just a question inline but since it builds with self-hosted I'm pretty sure I know the answer; just asked to confirm understanding.
| TSCBasic | ||
| TSCUtility) | ||
| target_link_libraries(Basics PRIVATE | ||
| TSCclibc) |
Contributor
There was a problem hiding this comment.
Because this is private (and imported using @_implementationOnly), it doesn't introduce a requirement on having the headers for TSCclibc around for any clients of libSwiftPM, right? Getting rid of that was a good cleanup and we'd hate to give it up.
Contributor
Author
There was a problem hiding this comment.
yes, that was my plan - its the same setup as TSC has
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: the logic in Versioning does not belong in TSC, its a SwiftPM concern
changes: