Skip to content

Conversation

@tomerd
Copy link
Contributor

@tomerd tomerd commented Feb 5, 2021

motivation: the logic in Versioning does not belong in TSC, its a SwiftPM concern

changes:

  • mark Versioning as deprecated, this will move to SwiftPM
  • mark convertTagsToVersionMap as deprecated, this will move to SwiftPM

motivation: the logic in Versioning does not belong in TSC, its a SwiftPM concern

changes:
* mark Versioning as deprecated, this will move to SwiftPM
* mark convertTagsToVersionMap as deprecated, this will move to SwiftPM
@tomerd
Copy link
Contributor Author

tomerd commented Feb 5, 2021

@swift-ci please test

@tomerd
Copy link
Contributor Author

tomerd commented Feb 5, 2021

@abertelrud @neonichu

@tomerd
Copy link
Contributor Author

tomerd commented Feb 5, 2021

/home/buildnode/jenkins/workspace/pr-swift-tools-support-core-linux/branch-main/swift-tools-support-core/Tests/TSCBasicPerformanceTests/StringConversionsPerfTests.swift:19: error: StringConversionsPerfTests.testLongString : failed: The relative standard deviation of the measurements is 75.517% which is higher than the max allowed of 10.000%.

unrelated perf flakiness

@tomerd
Copy link
Contributor Author

tomerd commented Feb 5, 2021

@swift-ci please test linux

@tomerd tomerd merged commit 15db71f into swiftlang:main Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants