[Collections] listCollections always returns all configured collections #3565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `listCollections` has optional `identifiers` that if specified, only those collections are supposed to be fetched. However, the current implementation always fetches all configured collections because the logic for determining "missing" collections is flawed. Modification: Fix logic such that `listCollections` returns all or a subset of collections depending on `identifiers` param.
yim-lee
requested review from
abertelrud,
friedbunny,
neonichu and
tomerd
as code owners
Contributor
Author
|
@swift-ci please smoke test |
tomerd
reviewed
Jun 21, 2021
Contributor
|
@swift-ci please smoke test |
tomerd
approved these changes
Jun 21, 2021
Contributor
Author
|
@swift-ci please smoke test |
neonichu
approved these changes
Jun 21, 2021
yim-lee
added a commit
to yim-lee/swift-package-manager
that referenced
this pull request
Jun 21, 2021
…ns (swiftlang#3565) Motivation: `listCollections` has optional `identifiers` that if specified, only those collections are supposed to be fetched. However, the current implementation always fetches all configured collections because the logic for determining "missing" collections is flawed. Modification: Fix logic such that `listCollections` returns all or a subset of collections depending on `identifiers` param.
yim-lee
added a commit
that referenced
this pull request
Jun 22, 2021
…ns (#3565) (#3568) Motivation: `listCollections` has optional `identifiers` that if specified, only those collections are supposed to be fetched. However, the current implementation always fetches all configured collections because the logic for determining "missing" collections is flawed. Modification: Fix logic such that `listCollections` returns all or a subset of collections depending on `identifiers` param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
listCollectionshas optionalidentifiersthat if specified, only those collections are supposed to be fetched. However, the current implementation always fetches all configured collections because the logic for determining "missing" collections is flawed.Modification:
Fix logic such that
listCollectionsreturns all or a subset of collections depending onidentifiersparam.