Skip to content

Avoid testing library package with swiftbuild build system on Windows #8379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Avoid testing library package with swiftbuild build system on Windows #8379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions IntegrationTests/Tests/IntegrationTests/SwiftPMTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ final class SwiftPMTests: XCTestCase {
}
}

#if !os(Windows)
// SWBINTTODO: Windows fails to link this library package due to a "lld-link: error: subsystem must be defined" error. See https://github.com/swiftlang/swift-build/issues/310
Copy link
Contributor

@bkhouri bkhouri Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Instead of compile this out of the test, can we move this to it's own test and mark it skipped on windows?

Copy link
Contributor

@jakepetroules jakepetroules Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that in a separate change.

do {
try withTemporaryDirectory { tmpDir in
let packagePath = tmpDir.appending(component: "foo")
Expand All @@ -79,6 +81,7 @@ final class SwiftPMTests: XCTestCase {
//try sh(swiftTest, "--package-path", packagePath, "--build-system", "swiftbuild")
}
}
#endif
}

func testArchCustomization() throws {
Expand Down