Provide the downloadable metal toolchain to swiftbuild #9434
Conversation
rconnell9
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv and
plemarquand
as code owners
|
@swift-ci test |
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
Looks great! Just one had minor point of feedback about the correctness of handling $(inherited) in constructing the build settings.
|
@swift-ci test |
|
@swift-ci test |
| name: "SwiftBuildSupportTests", | ||
| dependencies: ["SwiftBuildSupport", "_InternalTestSupport", "_InternalBuildTestSupport"] | ||
| ), | ||
| .testTarget( |
There was a problem hiding this comment.
I think we should consider putting the new test in SwiftBuildSupportTests instead of creating a whole new test target since this is a fairly specific test
There was a problem hiding this comment.
I'll include a follow-up
|
@swift-ci test |
|
@swift-ci test windows self hosted |
|
@swift-ci test |
|
|
||
| #if os(macOS) | ||
| @Test( | ||
| .disabled("Require downloadable Metal toolchain"), |
There was a problem hiding this comment.
suggestion (non-blocking): is it possible to detect the location of the metal toolchain and enable the test if it's detected?
|
@swift-ci test macOS |
|
@swift-ci test windows |
# Conflicts: # Sources/SwiftBuildSupport/SwiftBuildSystem.swift
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test linux |
|
@swift-ci test |
|
@swift-ci Please Test Amazon Linux 2 |
|
@swift-ci test linux |
4 participants
Provide the downloadable metal toolchain to swiftbuild using EXTERNAL_TOOLCHAINS_DIR env variable
Motivation:
#9202 [Parity] error: unable to spawn process 'metal' (No such file or directory)
Requires CI to include Metal toolchain in order to enable Metal tests:
#9443