Support cancellation of subcommands in swift-syntax-dev-utils using Ctrl-C
#2172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/cancellation
branch
from
c2b2e7b to
2a361c9
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
1 similar comment
Member
Author
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Sep 8, 2023
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
... unfortunate that this isn't handled by Process :(
| try command.run() | ||
| } catch { | ||
| if !SigIntListener.hasReceivedSigInt { | ||
| // No point printing an error message if the user requested the termiation |
Contributor
There was a problem hiding this comment.
Suggested change
| // No point printing an error message if the user requested the termiation | |
| // No point printing an error message if the user requested the termination |
bnbarham
reviewed
Sep 8, 2023
| signal(SIGINT) { _ in | ||
| SigIntListener.hasReceivedSigInt = true | ||
| for process in SigIntListener.runningSubprocesses { | ||
| kill(process.processIdentifier, SIGINT) |
Contributor
There was a problem hiding this comment.
There's a Process.terminate and Process.interrupt you could use instead signalling directly
Member
Author
There was a problem hiding this comment.
Oh, nice. I didn’t know about that.
… Ctrl-C It’s really quite unfortunate that we need to do all this handling ourselves…
ahoppen
force-pushed
the
ahoppen/cancellation
branch
from
2a361c9 to
04cf52d
Compare
bnbarham
approved these changes
Sep 8, 2023
Member
Author
|
@swift-ci Please test |
kimdv
approved these changes
Sep 10, 2023
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s really quite unfortunate that we need to do all this handling ourselves…