Minor cleanup from if to guard statement
#3172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
rintaro
previously approved these changes
Oct 17, 2025
bnbarham
approved these changes
Oct 17, 2025
rintaro
reviewed
Oct 17, 2025
Sources/SwiftParser/Lookahead.swift
Outdated
|
|
||
| // If we don't have attributes, then it cannot be an accessor block. | ||
| if nextToken.rawTokenKind != .atSign { | ||
| guard self.at(.atSign) else { |
There was a problem hiding this comment.
Ah sorry, nextToken is peek(). This is a behavior change.
There was a problem hiding this comment.
Great catch, I guess this shows why at and peek(isAt:) are more explicit. Added a test case for this.
I think the guard is a lot easier to read here, noticed while reviewing swiftlang#3171.
ahoppen
commented
Oct 19, 2025
| get | ||
| var x: Int = 2 | ||
| { | ||
| @something |
There was a problem hiding this comment.
@rintaro Do you have an idea what kind of attribute would make sense here, I can’t think of anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the guard is a lot easier to read here, noticed while reviewing #3171.