Skip to content

Minor cleanup from if to guard statement #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor cleanup from if to guard statement #3172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftParser/Lookahead.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ extension Parser.Lookahead {
}

// If we don't have attributes, then it cannot be an accessor block.
if nextToken.rawTokenKind != .atSign {
guard self.peek(isAt: .atSign) else {
return false
}

Expand Down
12 changes: 12 additions & 0 deletions Tests/SwiftParserTest/DeclarationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3768,4 +3768,16 @@ final class UsingDeclarationTests: ParserTestCase {
"""
)
}

func testAccessorBlockAfterPatternBindingDeclWithAttribute() {
assertParse(
"""
var x: Int = 2
{
@something
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rintaro Do you have an idea what kind of attribute would make sense here, I can’t think of anything.

didSet {}
}
"""
)
}
}