Fix leading trivia is not applied if raw syntax is empty #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
ahoppen
reviewed
Feb 25, 2022
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me. I think the current test coverage is fine. AFAICT we don’t have any tests at the RawSyntax level at the moment.
kimdv
force-pushed
the
kimdv/fix-not-passing-trivia
branch
from
1f6d784 to
ac894cd
Compare
Contributor
Author
|
@swift-ci Please test |
ahoppen
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we should create a test class for
RawSyntaxwhere we can add the test case, or it is enough with the current ones