When saving a String as an attachment, assume ".txt" as a path extension.
#1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tension. When a string is attached to a test, we encode it as UTF-8 (as is tradition). This PR adjusts `String`'s conformance to `Attachable` so that it uses the `".txt"` extension (unless the user specifies something else). This improves usability in Xcode test reports by making these attachments double-clickable and QuickLookable (is that a word?)
grynspan
requested review from
briancroom,
jerryjrchen and
stmontgomery
as code owners
grynspan
added
enhancement
jerryjrchen
approved these changes
Nov 7, 2025
Contributor
jerryjrchen
left a comment
jerryjrchen
left a comment
There was a problem hiding this comment.
QuickLookable (is that a word?)
Maybe "Quickly Lookable" :)
grynspan
commented
Nov 7, 2025
| } | ||
|
|
||
| /// @Metadata { | ||
| /// @Available(Swift, introduced: 6.2) |
Contributor
Author
There was a problem hiding this comment.
The conformance was introduced in 6.2, so yes this is accurate. :)
stmontgomery
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a string is attached to a test, we encode it as UTF-8 (as is tradition). This PR adjusts
String's conformance toAttachableso that it uses the".txt"extension (unless the user specifies something else). This improves usability in Xcode test reports by making these attachments double-clickable and QuickLookable (is that a word?)Checklist: