#expect(throws:) expression should accept non-Void return type and describe returned values #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
#expect(throws:)and similar macros so that their closure parameters accept any type instead ofVoidspecifically.Motivation:
This makes testing trivial throwing expressions of non-
Voidtypes easier, by not requiring syntax to discard the return value. For example:Modifications:
Rtype instead ofVoid.__check...functions to include a description of return value.Result:
The changes in this PR mean the warning above will no longer be emitted by the compiler. These changes also allow printing a description of the return value if the expectation fails and the expression does not throw an error, providing a more detailed and actionable failure message.