Use CodeBlockItemListSyntax instead of ExprSyntax when constructing a test function thunk.
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a test function thunk. This PR corrects a technical defect in `TestDeclarationMacro`. There should be no developer- or user-facing impact.
grynspan
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
stmontgomery and
suzannaratcliff
as code owners
|
@swift-ci please test |
stmontgomery
approved these changes
Oct 3, 2023
grynspan
deleted the
jgrynspan/use-code-block-item-list-syntax-in-test-macro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a technical defect in
TestDeclarationMacro. There should be no developer- or user-facing impact.Previously,
CodeBlockItemListSyntaxdidn't conform toSyntaxExpressibleByStringInterpolationso we would have had to manually construct it. Instead, we just substitutedExprSyntaxwhich is wrong, but allows string interpolation. This was corrected with swiftlang/swift-syntax#1946, so we can use the right type now.