[LSP/BSP] Separate base message protocol for LSP and BSP message types #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
ahoppen,
bnbarham,
hamishknight and
owenv
as code owners
owenv
reviewed
Oct 30, 2025
| @@ -0,0 +1,15 @@ | |||
| //===----------------------------------------------------------------------===// | |||
There was a problem hiding this comment.
I think this file is missing from the CMake build
There was a problem hiding this comment.
Good catch, thank you! updated.
Introduce `LSPRequest`, `LSPNotification`, `BSPRequest`, and `BSPNotification`. And change the protocol of the each concrete type. This is beneficial for implementing LSP/BSP only message handlers.
rintaro
force-pushed
the
base-message-protocols
branch
from
6ee41d0 to
81df13c
Compare
owenv
approved these changes
Oct 30, 2025
ahoppen
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synced update for swiftlang/sourcekit-lsp#2342
Introduce
LSPRequest,LSPNotification,BSPRequest, andBSPNotification. And change the protocol of the each concrete type. This is beneficial for implementing LSP/BSP only message handlers.