Add new playground types #21
Conversation
Needed to get playground support into SourceKit-LSP: swiftlang/sourcekit-lsp#2340
award999
requested review from
ahoppen,
bnbarham,
hamishknight,
owenv and
rintaro
as code owners
| /// This property is always present whether the `Playground` has a `label` or not. | ||
| /// | ||
| /// Follows the format output by `swift play --list`. | ||
| public var id: String |
There was a problem hiding this comment.
I think this needs to capture either the corresponding product or target as well so that the playground can be executed in the appropriate context
There was a problem hiding this comment.
@owenv the LSP code that parses these does include the target https://github.com/swiftlang/sourcekit-lsp/pull/2340/files#diff-d76b1dc09dd52af2a88684043d44d1e5261f013c09f6137dffd4e23aebce6e56R91 but do you want the comment code to reflect the expected format?
There was a problem hiding this comment.
I added a better explanation about id but let me know if there is more you wanted
There was a problem hiding this comment.
Hmm, so it seems like the playgrounds implementation is building a dylib composed of every target in the package and linking the runner against that. This will work in small examples, but in general it's not safe to assume all the targets in a package can be safely linked into a single image. e.g. they may have different platform requirements, conflicting static initializers, multiple copies of a binary dependency built from the same sources, etc. I think sourcekit-lsp will need to pick a single specific appropriate library product containing the playground's code, thread that through to the play command, and adjust the build of the runner accordingly
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
A couple small comments, otherwise LGTM.
| case .dictionary(let locationDict) = dictionary["location"], | ||
| let location = Location(fromLSPDictionary: locationDict) |
There was a problem hiding this comment.
This can be shortened slightly.
| case .dictionary(let locationDict) = dictionary["location"], | |
| let location = Location(fromLSPDictionary: locationDict) | |
| let location = Location(fromLSPAny: dictionary["location"]) |
| /// location of the playground and identifiers to allow executing the playground through a "swift play" command. | ||
| /// | ||
| /// **(LSP Extension)** | ||
| public struct Playground: ResponseType, Equatable, LSPAnyCodable { |
There was a problem hiding this comment.
This isn’t used anywhere yet, right? Do you want to introduce the workspace/playgrounds request in this PR already or in a follow-up PR? I’m fine with either.
| case .dictionary(let rangeDict) = dictionary["range"], | ||
| let range = Range<Position>(fromLSPDictionary: rangeDict) |
There was a problem hiding this comment.
Same here, we can use the init(fromLSPAny:) convenience initializer.
| case .dictionary(let rangeDict) = dictionary["range"], | |
| let range = Range<Position>(fromLSPDictionary: rangeDict) | |
| let range = Range<Position>(fromLSPAny: dictionary["range"]) |
3 participants
Needed to get playground support into SourceKit-LSP: swiftlang/sourcekit-lsp#2340