Skip to content

Add an overload of exec(path:args:) which returns Never #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomerd merged 1 commit into from
Jun 23, 2021
Merged

Add an overload of exec(path:args:) which returns Never #227

tomerd merged 1 commit into from
Jun 23, 2021

Conversation

@jakepetroules
Copy link
Contributor

@jakepetroules jakepetroules commented Jun 22, 2021

No description provided.

@jakepetroules
Copy link
Contributor Author

jakepetroules commented Jun 22, 2021

@swift-ci please test

@neonichu
Copy link
Contributor

neonichu commented Jun 22, 2021

The Linux failure is known but we don't know yet why it is happening and how to fix it.

@tomerd
Copy link
Contributor

tomerd commented Jun 23, 2021

The Linux failure is known but we don't know yet why it is happening and how to fix it.

@neonichu @abertelrud is one of you looking into it? is it a test issue or a code issue?

@tomerd tomerd merged commit 2bec1a3 into main Jun 23, 2021
@jakepetroules jakepetroules deleted the execnever branch June 23, 2021 01:39
@neonichu
Copy link
Contributor

neonichu commented Jun 23, 2021 •
edited
Loading

@neonichu @abertelrud is one of you looking into it? is it a test issue or a code issue?

I was looking into this quite a bit and haven't been able to reproduce it myself (using a prebuilt 5.5 toolchain instead of building one myself, though). I'm pretty sure it is just a test issue since the underlying feature seems to work fine in that same configuration for me (5.5 on Ubuntu 16).

Another oddity is that we are only seeing this on TSC CI, but the tests are SwiftPM tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neonichu neonichu neonichu approved these changes

@BenchR267 BenchR267 BenchR267 approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@abertelrud abertelrud Awaiting requested review from abertelrud

@friedbunny friedbunny Awaiting requested review from friedbunny

@tomerd tomerd Awaiting requested review from tomerd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jakepetroules @neonichu @tomerd @BenchR267