[NFC] Replace type-erased pattern matching with typed if-else blocks #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an unreachable `default` case, and should result in a little less runtime cost.
WowbaggersLiquidLunch
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
@swift-ci test |
elsh
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Concrete types are better than
Any.Result: This removes an unreachable
defaultcase, and should result in a bit less runtime cost.Same as swiftlang/swift-package-manager#3840, but for TSC's
Version.