TSCBasic: remove close overload in extension
#265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FileHandle` extension added an overloaded `close` that causes ambiguity when using `close` on a `FileHandle`. This manifested as a build failure with swiftlang/swift-package-manager#3888. Remove the function as swift-driver, swift-package-manager, and sourcekit-lsp are able to build without this function (relying on Foundation to provide it).
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
Member
Author
|
@swift-ci please test |
Member
Author
|
CC: @abertelrud |
abertelrud
approved these changes
Nov 30, 2021
Contributor
|
I just realized what happened here. These were old covers that are no longer needed now that Foundation has refined its FileHandle API in Swift 5.0. |
Contributor
|
That means that if this causes problems, I can also switch SwiftPM to use the deprecated |
Contributor
|
@compnerd Looks ready to go at this point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileHandleextension added an overloadedclosethat causesambiguity when using
closeon aFileHandle. This manifested as abuild failure with swiftlang/swift-package-manager#3888. Remove the
function as swift-driver, swift-package-manager, and sourcekit-lsp are
able to build without this function (relying on Foundation to provide
it).