Always parse the ABI component of target triples #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonichu
requested review from
abertelrud,
aciidgh,
friedbunny and
tomerd
as code owners
Contributor
Author
|
@swift-ci please test |
tomerd
approved these changes
Jun 23, 2022
tomerd
reviewed
Jun 23, 2022
tomerd
reviewed
Jun 23, 2022
neonichu
force-pushed
the
always-parse-abi-in-triple
branch
from
a95ea9c to
defe7c3
Compare
Contributor
|
@swift-ci smoke test |
Contributor
|
@swift-ci test |
Previously, we were ignoring the ABI component unless it started with the literal string "android". This seems incorrect, we should be including any type of ABI component if it is present in a triple.
neonichu
force-pushed
the
always-parse-abi-in-triple
branch
from
defe7c3 to
a070244
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were ignoring the ABI component unless it started with the literal string "android". This seems incorrect, we should be including any type of ABI component if it is present in a triple.