[SR-2426] compiler needs to permit `sender` to be Any in `@IBAction` funcs

[mattneub]

Previous ID	SR-2426
Radar	rdar://problem/27853737
Original Reporter	@mattneub
Type	Bug
Status	Resolved
Resolution	Done

Environment

Xcode Version 8.0 beta 6 (8S201h)

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug
Assignee	None
Priority	Medium

md5: 58ac2bdb30ba59138e7ec74200e17519

Issue Description:

This doesn't compile:

    @IBAction func doButton (_ sender:Any!) { // ...

The compiler complains: Argument to @IBAction method cannot have non-object type 'Any!'. This complaint is spurious; all objects arriving from Objective-C are now arriving as Any, and there is no reason why IBAction methods should not do the same.

The proof is that if, having created my outlet in IB, I now delete the word @IBAction, I can change AnyObject to Any and the method compiles and works perfectly.

Thus I argue that this compile error is a dinosaur and should be expunged. With all Objective-C objects arriving as Any, my code looks silly with this smattering of AnyObject usages sticking out like a sore thumb. I should be able to change them to Any.

(I have also filed a radar asking that Interface Builder should offer Any as an alternative when it forms the action handler signature automatically.)

[belkadan]

Fixed in master in #4320 :-)

[swift-ci]

Comment by Kirk Peart (JIRA)

Just encountered this error in Version 8.0 (8A218a) of Xcode.

Code block is pasted in below. Is this fixed in 8.0?

@IBAction func buttonAction(_ notification: Notification) {
let userInfo:Dictionary<String,UIGestureRecognizer?> = (notification as NSNotification).userInfo as! Dictionary<String,UIGestureRecognizer?>
let sender = userInfo["sender"]

DDLogDebug("sender: (sender)")

let button = sender UIButton
let soundName = button.currentTitle!

//self.buttonContentViewFromPageView = userInfo["superview"]!.view
self.buttonContentViewFromPageView = button.superview?.superview

DDLogDebug("SleepEZViewController.buttonAction: Notificaiton!")
DDLogDebug("SleepEZViewController.buttonAction: Posted Notification sleepEZButtonActionNotificationKey to initiate buttonAction")
DDLogDebug("SleepEZViewController.buttonAction: Button Name: (soundName)")
DDLogDebug("")

// for long press send to addToFavorites
if sender is UILongPressGestureRecognizer && sender!?.state == UIGestureRecognizerState.began {
addToFavorites(button)

// make little sparkle
backgroundImageView.twinkle()

button.twinkle()
}

// for tap send to sleepSound and determine how to highlight button
if sender is UITapGestureRecognizer {

// clean this up so it's more OO style because the decision to play should be inherently
// linked to the decision to highlight the button whose sound is playing
if playSleepSound.currentMixButtonSounds.contains(soundName) {

// change border back to white if already playing the clicked button's sound
button.buttonBorderDefault()
} else {

if !mixSwitch.isOn {

// deselect all
createButtonObject.deselectAllButtons(self.buttonContentViewFromPageView)
}

// change button border color to indicate playing sound
button.buttonBorderHighlighted()
}

// determine to play sound or not
sleepSound(button)

// anmiate button
createButtonObject.animateSelectButton(button)
}
}

[swift-ci]

Comment by Kirk Peart (JIRA)

Reopening based on encountering in this error in Version 8.0 (8A218a) of Xcode.

Code block is pasted in previous comment.

[swift-ci]

Comment by Kirk Peart (JIRA)

just realizing my compiler error was on Notification not Any, therefore may or may not be relevant. Please review.

Thanks

[belkadan]

Yeah, NotificationCenter callbacks are not considered IBActions. It's okay that the compiler rejects this.