Skip to content

[Parse] Don't invalidate compilation condition with invalid platform condition argument #10221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2017
Merged

[Parse] Don't invalidate compilation condition with invalid platform condition argument #10221

merged 1 commit into from
Jun 14, 2017

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented Jun 13, 2017 

#if arch(x86_64) || arch(ppc64) // Even while "ppc64" is not supported argument ...
   // Code here should be active in x86_64
#endif

The issue was introduced in #7955 by me.
It breaks code that should compile. e.g. swiftlang/swift-corelibs-foundation#1026

@rintaro
Copy link
Member Author

rintaro commented Jun 13, 2017

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor

jrose-apple commented Jun 13, 2017 •
edited
Loading

Can you write a test where the branch is skipped as well? We want unknown tests with arguments to be treated as false.

@rintaro rintaro force-pushed the parse-ifconfig-invalid-platformarg branch from e19daa7 to 00460a7 Compare June 13, 2017 17:41
@rintaro rintaro force-pushed the parse-ifconfig-invalid-platformarg branch from 00460a7 to fab3a98 Compare June 13, 2017 17:43
@rintaro rintaro changed the title [Parse] Don't invalidate the condition with invalid platform condition argument [Parse] Don't invalidate compilation condition with invalid platform condition argument Jun 13, 2017
@rintaro
Copy link
Member Author

rintaro commented Jun 13, 2017

Added a test case.
@swift-ci Please smoke test

@DougGregor
Copy link
Member

Looks great, feel free to merge.

@rintaro rintaro merged commit 4c6ece6 into swiftlang:master Jun 14, 2017
@rintaro rintaro deleted the parse-ifconfig-invalid-platformarg branch June 14, 2017 06:09
@rintaro rintaro mentioned this pull request Jun 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rintaro @jrose-apple @DougGregor