[4.0][Parse] Don't invalidate compilation condition with invalid platform condition argument #10356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…condition argument It's just a warning.
|
@swift-ci Please test |
|
@DougGregor Could you re-review this for 4.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #10221 into 4.0
Explanation: Fix a 4.0 regression where compilation condition with platform condition with unsupported argument was unexpectedly invalidated. For example
#if arch(x86_64) || arch(ppc64)should evaluates totrueforx86_64target even whileppc64is not valid argument forarch()platform condition. The issue was introduced in #7955. This is a regression that breaks existing code. e.g. swiftlang/swift-corelibs-foundation#1026Scope: Affects
#ifand#elseifcondition which contains unsupported arguments for platform conditionos(),arch(), and_endian()SR Issue: N/A
Risk: Low
Testing: Added test cases.