SILGen: Fix linkage for stored property initializers of private properties [4.0] #10855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties Always give stored property initializers the linkage of the type that contains them, even if the property is less visible than the type. This fixes the case where a type defines a private property, and an extension in a different file from the same module defines a constructor. Fixes <rdar://problem/32743703>.
slavapestov
changed the title
|
@swift-ci Please test |
|
Looks good. |
jckarter
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a regression with extensions of a type that has stored properties with initializer expressions.
Scope of the issue: Reported as a regression by a user.
Origination: Introduced in 4.0 beta 1.
Tested: New tests added
Reviewed by: @jckarter
Radar: rdar://problem/32743703