Introduce a command-line option to limit the # of typo corrections. #10859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo correction can be particularly expensive, so introduce a command-line flag to limit the number of typo corrections we will perform per type-checker instance. Default this limit to 10. Addresses rdar://problem/28469270 to some extent. (cherry picked from commit f03685b)
(cherry picked from commit 7deafb2)
|
@swift-ci please test |
huonw
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Typo correction can be expensive, because it walks fairly large data structures (both in-memory and on-disk) and does a bunch of work. Limit the number of times a particular Swift invocation will perform typo correction (to 10, with a flag to change the limit). Clang has done this "forever" and it's helpful there.
Scope: Typically only affects "very broken" code, e.g., where one has pasted a bunch of code and forgotten an "import". But when it happens, the Swift type checker gets very slow and eats up a lot of memory.
Radar: rdar://problem/28469270
Risk: Very low; limits existing behavior on code that produces > 10 typo correct diagnostics.
Testing: Compiler regression testing