Skip to content

[swift-4.0-branch][overlay] Hide the _ExpressibleByColorLiteral initializer #10934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2017
Merged

[swift-4.0-branch][overlay] Hide the _ExpressibleByColorLiteral initializer #10934

merged 2 commits into from
Jul 13, 2017

Conversation

@moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 13, 2017

  • Explanation: This change hides the initializer introduced by the internal protocol, to avoid its misuses where initializers from concrete types should be used instead.
  • Scope of Issue: Change provides the backward compatible overload (marked as deprecated)
  • Risk: Minimal
  • Reviewed By: Ben Cohen
  • Testing: Test suite + compatiblity test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/32726800

Max Moiseev added 2 commits July 13, 2017 10:48
[overlay] Hide the _ExpressibleByColorLiteral initializer from code c…
2a84095 
…ompletion.

Fixes: <rdar://problem/32726800>
(cherry picked from commit 391d49a)
Add an @available initializer for source compatibility
04b09a7 
(cherry picked from commit d9e0eef)
@moiseev
Copy link
Contributor Author

moiseev commented Jul 13, 2017

@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Jul 13, 2017

Similar to #10856

@moiseev moiseev mentioned this pull request Jul 13, 2017
Merged
@moiseev moiseev merged commit 3b150b3 into swiftlang:swift-4.0-branch Jul 13, 2017
@moiseev moiseev deleted the color-literal-init-4 branch July 13, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@moiseev