[4.0] Sema: Coerce the type of the index expression in a key path component to match the subscript decl's index type. #12303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to match the subscript decl's index type. Fixes SR-6062 | rdar://problem/34835322.
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@slavapestov Mind reviewing this for the 4.0 branch? |
slavapestov
approved these changes
Oct 5, 2017
jckarter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The compiler would crash when a key path literal with subscript components contained indexes that were a subtype of the subscript's expected index parameters.
Scope: Fixes a bug in key path subscripts, a new feature added after the first release of 4.0.
Issue: SR-6062 | rdar://problem/34835322
Risk: Low, small bug fix
Testing: Swift CI, test case from Jira, compatibility suite