Take the IUO-ness of a parameter declaration into account in ranking. #15496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally we wouldn't need this because we do not allow overloading by parameter optionality. In this case, though, we import two Objective-C methods that end up getting renamed to the same name in Swift, one of which has a nullability annotation and the other of which doesn't. Before IUOs were removed from the type system, we would have failed a subtype test when ranking overloads, but now that subtype test passes because we're comparing two optionals of the same type. So the change here is to compare the optionality of the parameters and reject cases where we are testing whether a plain optional is a subtype of something declared to be an IUO. Fixes rdar://problem/38719575. (cherry picked from commit 0959f0c)
Contributor
Author
|
@swift-ci Please test |
1 similar comment
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
The source compatibility suite failures are unrelated to my changes, and I've opened a PR to XFAIL most of them: swiftlang/swift-source-compat-suite#169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we wouldn't need this because we do not allow overloading by
parameter optionality. In this case, though, we import two Objective-C
methods that end up getting renamed to the same name in Swift, one of
which has a nullability annotation and the other of which doesn't.
Before IUOs were removed from the type system, we would have failed a
subtype test when ranking overloads, but now that subtype test passes
because we're comparing two optionals of the same type. So the change
here is to compare the optionality of the parameters and reject cases
where we are testing whether a plain optional is a subtype of
something declared to be an IUO.
Fixes rdar://problem/38719575.
(cherry picked from commit 0959f0c)