Coverage: fix handling of constructors and top-level decls (SR-7446)… #16001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wiftlang#15966) * [Coverage] Instrument constructor initializers (SR-7446) We need to instrument constructor initializers, instead of the delegating constructors which just call them. rdar://39460313 * [Coverage] Remove dead code, NFC * [Coverage] Use a shared profiler for constructors and member initializers This fixes coverage reporting for member initializers and cuts down on repeated AST traversals of pattern bindings within nominal type decls. This allows us to remove some defensive heuristic code which dealt with closures and if-exprs within member initializers. (cherry picked from commit 8a003a4)
Contributor
Author
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#15966)
We need to instrument constructor initializers, instead of the
delegating constructors which just call them.
rdar://39460313
[Coverage] Remove dead code, NFC
[Coverage] Use a shared profiler for constructors and member initializers
This fixes coverage reporting for member initializers and cuts down on
repeated AST traversals of pattern bindings within nominal type decls.
This allows us to remove some defensive heuristic code which dealt with
closures and if-exprs within member initializers.
(cherry picked from commit 8a003a4)
Resolves SR-7446.