Skip to content

Conversation

@airspeedswift
Copy link
Member

@airspeedswift airspeedswift commented May 3, 2018

Now that Range is conditionally a Sequence, CountableRange is redundant and implemented as a generic typealias for source compatibility.

However, it's still useful shorthand for a Range that is countable. This change removes the deprecation on the typealias, for now, pending feedback.

@airspeedswift
Copy link
Member Author

@swift-ci please test source compatibility

@airspeedswift
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 3, 2018

Build failed
Swift Test Linux Platform
Git Sha - 09cc7a7a28494a505b5988555f9bc14ae3f00715

@swift-ci
Copy link
Contributor

swift-ci commented May 3, 2018

Build failed
Swift Test OS X Platform
Git Sha - 09cc7a7a28494a505b5988555f9bc14ae3f00715

@airspeedswift airspeedswift force-pushed the undeprecate-countable-range branch from 09cc7a7 to 51b9468 Compare May 4, 2018 16:31
@airspeedswift
Copy link
Member Author

@swift-ci please test

@airspeedswift
Copy link
Member Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2018

Build failed
Swift Test OS X Platform
Git Sha - 09cc7a7a28494a505b5988555f9bc14ae3f00715

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - 09cc7a7a28494a505b5988555f9bc14ae3f00715

@airspeedswift
Copy link
Member Author

@swift-ci please test linux platform

@airspeedswift airspeedswift requested a review from DougGregor May 4, 2018 23:30
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. CountableRange is a useful name, even as a shorthand, and we've seen that it's fairly widely used.

@airspeedswift airspeedswift merged commit f421ec6 into swiftlang:master May 7, 2018
airspeedswift added a commit to airspeedswift/swift that referenced this pull request May 24, 2018
* Undeprecate Countable*Range

* Remove check for deprecation warnings
airspeedswift added a commit that referenced this pull request May 24, 2018
* Undeprecate Countable*Range

* Remove check for deprecation warnings
@airspeedswift airspeedswift deleted the undeprecate-countable-range branch August 18, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants