[4.2 04-30] Fixes for String performance regressions #16735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beside the general goal to remove inlinable functions, this reduces code size and also improves performance for several benchmarks. The performance problem was that by inlining top-level String API functions into client code (like String.count) it ended up calling non-inlinable internal String functions eventually. This is much slower than to make a single call at the top-level API boundary into the library. Inside the library all the internal String functions can be specialized and inlined. rdar://problem/39921548
Re-wrote the inner memcpy loops so that they can be vectorized. Also added a few inline(__always). Since we removed some @inlineable attributes this string-append code is not code generated in the client anymore. The code generation in the stdlib binary is different because all the precondition checks are not folded away. Using explicit loop control statements instead of for-in-range removes the precondition-overhead for those time critical memcpy loops.
Contributor
Author
|
@swift-ci test |
eeckstein
changed the title
Contributor
Author
|
Explanation: These changes fix some major regressions, which were introduced with the new String implementation |
Contributor
|
Build failed |
Contributor
|
Build failed |
[test] Update diagnostic test for SR-7599
Contributor
Author
|
@swift-ci test |
Contributor
|
Build failed |
Member
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details see commits.
rdar://problem/39978743