[IRGen] Do not use ObjC tagged-pointer logic on non-ObjC platforms #16826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davezarzycki
requested review from
eeckstein,
gottesmm,
gparker42,
rjmccall and
slavapestov
Contributor
Author
|
@swift-ci please test |
Contributor
|
Seems reasonable, but @jckarter should take a look, too. |
Contributor
|
Build failed |
Contributor
|
The imminent ABI freeze is only for ObjC platforms, but this looks good at a glance. |
Please note that some ObjC tests moved out of test/IRGen/enum.sil and into test/IRGen/enum_objc.sil because `#if` does not work with SIL keywords.
davezarzycki
force-pushed
the
drop_objcism_from_non_objc_platforms
branch
from
7d229a1 to
4abed13
Compare
Contributor
Author
|
GitHub review approval would be appreciated. Thanks! @swift-ci please smoke test |
jckarter
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something to squeeze in before the ABI freeze (I hope).