[sourcekit] Fix a race between AST processing and reopening a document #18160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
benlangmuir
force-pushed
the
edit-test-race
branch
from
f68b535 to
72e39ee
Compare
Contributor
Author
|
@swift-ci please smoke test |
I haven't found any cases where this changes the visible behaviour of the test, but having the file remain open across invocations was certainly unexpected and affects how the first part of the test works at runtime.
When a document is opened twice without closing it we re-initialize its internal data. Make sure we don't race with code that accesses that data. Found by TSan!
benlangmuir
force-pushed
the
edit-test-race
branch
from
72e39ee to
a8d5493
Compare
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a document is opened twice without closing it we re-initialize its internal data. Make sure we don't race with code that accesses that data.
This could have broken the unit test
EditTest.DiagsAfterReopen. It's unlikely it impactsEditTest.DiagsAfterCloseAndReopen.Found by TSan!