Skip to content

[5.0] SILOptimizer: avoid accessing the class properties if not necessary in redundant load elimination #20431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
Merged

[5.0] SILOptimizer: avoid accessing the class properties if not necessary in redundant load elimination #20431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions lib/SIL/Projection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,20 +599,7 @@ ProjectionPath::expandTypeIntoLeafProjectionPaths(SILType B, SILModule *Mod,

LLVM_DEBUG(llvm::dbgs() << "Visiting type: " << Ty << "\n");

// Get the first level projection of the current type.
Projections.clear();
Projection::getFirstLevelProjections(Ty, *Mod, Projections);

// Reached the end of the projection tree, this field can not be expanded
// anymore.
if (Projections.empty()) {
LLVM_DEBUG(llvm::dbgs() << " No projections. "
"Finished projection list\n");
Paths.push_back(PP);
continue;
}

// If this is a class type, we also have reached the end of the type
// If this is a class type, we have reached the end of the type
// tree for this type.
//
// We do not push its next level projection into the worklist,
Expand All @@ -635,6 +622,19 @@ ProjectionPath::expandTypeIntoLeafProjectionPaths(SILType B, SILModule *Mod,
continue;
}

// Get the first level projection of the current type.
Projections.clear();
Projection::getFirstLevelProjections(Ty, *Mod, Projections);

// Reached the end of the projection tree, this field can not be expanded
// anymore.
if (Projections.empty()) {
LLVM_DEBUG(llvm::dbgs() << " No projections. "
"Finished projection list\n");
Paths.push_back(PP);
continue;
}

// Keep expanding the location.
for (auto &P : Projections) {
ProjectionPath X(B);
Expand Down