[5.0] SILOptimizer: avoid accessing the class properties if not necessary in redundant load elimination #20431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n redundant load elimination The fix here is to just swap two bail-out conditions. It's a NFC regarding the performed optimization, but it avoids importing class properties, which is not needed. This is a speculative fix for rdar://problem/45806457
Contributor
Author
|
@swift-ci test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci smoke test macos |
Contributor
Author
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix here is to just swap two bail-out conditions.
It's a NFC regarding the performed optimization, but it avoids importing class properties, which is not needed.
This is a speculative fix for rdar://problem/45806457