[AD] struct_extract result is varied only if field isn't @noDerivative
#21899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a stored property of a struct with synthesized Differentiable conformance is of a type that conforms to Differentiable, but is marked `@noDerivative`, a struct_extract instruction that extracts that property shouldn't propagate variedness to its result.
rxwei
approved these changes
Jan 16, 2019
| if (isVaried(cai->getSrc(), i)) | ||
| recursivelySetVariedIfDifferentiable(cai->getDest(), i); | ||
| } | ||
| else if (auto *sei = dyn_cast<StructExtractInst>(&inst)) { |
Contributor
There was a problem hiding this comment.
You'll also want to check whether CotangentVector is @_fieldwiseProductSpace, because if it's not, we consider @noDerivative as having had no effect on conformance synthesis, so it could still have a VJP we would call when it's active.
It would be nice to move the code that checks for @_fieldwiseProductSpace into a helper.
Co-Authored-By: jekbradbury <jekbradbury@gmail.com>
Author
|
@swift-ci test tensorflow |
Author
|
@swift-ci please test tensorflow |
1 similar comment
Contributor
|
@swift-ci please test tensorflow |
Author
|
Failure was a timeout. OK to merge @rxwei? |
Contributor
|
yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a stored property of a struct with synthesized
Differentiableconformance is of a type that conforms to
Differentiable, but ismarked
@noDerivative, a struct_extract instruction that extractsthat property shouldn't propagate variedness to its result.