Skip to content

[AutoDiff] Fix memory leaks. #22169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2019
Merged

[AutoDiff] Fix memory leaks. #22169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/SILOptimizer/Mandatory/Differentiation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4396,8 +4396,13 @@ void DifferentiationTask::createVJP() {
// This assumes that the primal direct results correspond exactly to the
// adjoint's direct parameters, an assumption that we check in assertions
// above.
builder.createRetainValue(loc, primalDirectResults[dirResIdx],
builder.getDefaultAtomicity());
//
// If this is not the primal value struct (index 0), it must be an
// original result. Retain it because we'll return original results
// alongside the pullback.
if (dirResIdx != 0)
builder.createRetainValue(loc, primalDirectResults[dirResIdx],
builder.getDefaultAtomicity());
partialAdjointArgs.push_back(primalDirectResults[dirResIdx++]);
} else {
// This assumes that the primal indirect results correspond exactly to the
Expand Down