[AutoDiff] Fix partial_apply substitution map logic.
#22240
Merged
+70
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate derivative's substitution map in `reapplyFunctionConversion` for `partial_apply` instructions. When reapplying a `partial_apply` instruction, the associated derivative function's substitution map should be used, not the original function's. This is because the derivative function may have more generic requirements than the original function. Revamp `test/TensorFlowRuntime/model_autodiff_runtime.swift` to use imported TensorFlow high-level APIs (layers and optimizers). Resolves SR-9799.
dan-zheng
force-pushed
the
fix-differentiation-partial-apply-substs
branch
from
1a7d110 to
f42feea
Compare
slavapestov
reviewed
Jan 30, 2019
slavapestov
reviewed
Jan 30, 2019
rxwei
approved these changes
Jan 30, 2019
rxwei
reviewed
Jan 30, 2019
Address comments by @rxwei.
- Create `assocFn` without generic environment. - Clean up substitution map logic. - Compute `partial_apply` substitution map using derivative generic signature. Address comments from @slavapestov.
Contributor
Author
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propagate derivative's substitution map in
reapplyFunctionConversionforpartial_applyinstructions. When reapplying apartial_applyinstruction,the associated derivative function's substitution map should be used, not
the original function's. This is because the derivative function may have
more generic requirements than the original function.
Revamp
test/TensorFlowRuntime/model_autodiff_runtime.swiftto use importedTensorFlow high-level APIs (layers and optimizers).
This file acts as CI for
tensorflow-swift-apis.Resolves SR-9799. Exposes a new crasher: SR-9806.