-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Allow for passing a custom Archetype naming schema to the demangler. #22997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for passing a custom Archetype naming schema to the demangler. #22997
Conversation
|
@swift-ci test |
slavapestov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call them generic parameters and not "archetypes" here?
|
Are you saying that we should rename I'm happy to do that, I just always thought that |
|
Build failed |
|
Yeah, I would prefer if we not use the term "archetype" in the demangler at all. It's an implementation detail of the compiler. |
|
Works for me. I'll open a separate PR to rename everything. |
58c93f1 to
ceacd55
Compare
|
Build failed |
Fixes <rdar://problem/48004306>. (cherry picked from commit d0c7b15)
(cherry picked from commit 2c01516)
This is done by disallowing nodes with children to also have index or text payloads. In some cases those payloads were not needed anyway, because the information can be derived later. In other cases the fix was to insert an additional child node with the index/text payload. Also, implement single or double children as "inline" children, which avoids needing a separate node vector for children. All this reduces the needed size for node trees by over 2x.
LLDB would like to substitute the original Archetype names from the source code when demangling symbols instead of the confusing generic 'A', 'B', ... <rdar://problem/48259889>
ceacd55 to
ef115cf
Compare
|
@swift-ci test and merge |
|
@swift-ci test and merge |
Cherry-pick of #22954
rdar://problem/48259889