Swift reflection test deps #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes some harmless but annoying log spew. "swift-reflection-test" only exists on disk as a target executable with the variant suffix tacked on the end, so don't infer the binary location.
Eventually this tool will test solely with the C API, so wire up the dependencies now. This also fixes an annoying dependency issue when building some testing configurations. rdar://problem/25943881
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
Looks like an unrelated LLDB failure. I'll merge. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes swift-reflection-test dependencies for uncommon build presets and links the test tool against the C library to better reflect the usage scenario. As a follow-up, we'll remove any use of the C++ APIs in the test tool.
rdar://problem/25943881