Skip to content

Conversation

@tanmayb123
Copy link

Moving relevant ops & gradients to swift-apis (PR: tensorflow/swift-apis#63)

@rxwei
Copy link
Contributor

rxwei commented Mar 29, 2019

@swift-ci please test tensorflow

@tanmayb123
Copy link
Author

Seems like there's a bunch of errors since swift-apis can't find the right operations & such.

@tanmayb123
Copy link
Author

I also forgot to remove the tests. Just did that.

@rxwei
Copy link
Contributor

rxwei commented Mar 29, 2019

I updated swift-apis' checkout hash for you.

@rxwei
Copy link
Contributor

rxwei commented Mar 29, 2019

@swift-ci please clean test tensorflow

1 similar comment
@rxwei
Copy link
Contributor

rxwei commented Mar 29, 2019

@swift-ci please clean test tensorflow

@tanmayb123
Copy link
Author

Tests have passed. Anything else that needs to be added/removed here?

@rxwei rxwei merged commit a13eb43 into swiftlang:tensorflow Mar 29, 2019
@rxwei
Copy link
Contributor

rxwei commented Mar 29, 2019

Merged. Thanks.

rxwei pushed a commit to rxwei/swift that referenced this pull request May 11, 2019
* Remove ops (moved to swift-apis)

* Remove gradients (moved to swift-apis)

* Remove tests for ops moved to swift-apis

* Update checkout for 'tensoflow/swift-apis'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants