Skip to content

Invalidate analysis if we inline functions during deabstraction. #23663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Invalidate analysis if we inline functions during deabstraction. #23663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/SILOptimizer/Mandatory/TFDeabstraction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,11 @@ void TFDeabstraction::inlineCalls() {
auto &module = fn.getModule();
module.invalidateSILLoaderCaches();

if (!inlinedCallees.empty()) {
passManager->invalidateAnalysis(
&fn, SILAnalysis::InvalidationKind::FunctionBody);
}

// Now that we've inlined some functions, clean them up to avoid burning
// compile time in later passes. We do this with a simple linear scan,
// because functions that reference each other have already been flattened
Expand Down