[stdlib] Expanded string slicing test #2367

natecook1000 · 2016-05-02T16:37:03Z

What's in this pull request?

This updates the tests for substrings to include sharing indices with string view slices. The tests are currently xfail'd for CharacterView, UnicodeScalarView, and UTF16View.

Current test output:

[ RUN      ] SubstringTests.String
[       OK ] SubstringTests.String
[ RUN      ] SubstringTests.CharacterView (XFAIL: [Always(reason: CharacterView slices don't share indices)])
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.Character)
stdout>>> actual: "c" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "b" (of type Swift.Character)
stdout>>> actual: "d" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.Character)
stdout>>> actual: "g" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.Character)
stdout>>> actual: "C" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "C" (of type Swift.Character)
stdout>>> actual: "e" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "d" (of type Swift.Character)
stdout>>> actual: "f" (of type Swift.Character)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.Character)
stdout>>> actual: "g" (of type Swift.Character)
[    XFAIL ] SubstringTests.CharacterView
[ RUN      ] SubstringTests.UnicodeScalars (XFAIL: [Always(reason: UnicodeScalarsView slices don't share indices)])
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.UnicodeScalar)
stdout>>> actual: "c" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "b" (of type Swift.UnicodeScalar)
stdout>>> actual: "d" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.UnicodeScalar)
stdout>>> actual: "g" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "a" (of type Swift.UnicodeScalar)
stdout>>> actual: "C" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "C" (of type Swift.UnicodeScalar)
stdout>>> actual: "e" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "d" (of type Swift.UnicodeScalar)
stdout>>> actual: "f" (of type Swift.UnicodeScalar)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: "e" (of type Swift.UnicodeScalar)
stdout>>> actual: "g" (of type Swift.UnicodeScalar)
[    XFAIL ] SubstringTests.UnicodeScalars
[ RUN      ] SubstringTests.UTF16View (XFAIL: [Always(reason: UTF16View slices don't share indices)])
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 97 (of type Swift.UInt16)
stdout>>> actual: 99 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 98 (of type Swift.UInt16)
stdout>>> actual: 100 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 101 (of type Swift.UInt16)
stdout>>> actual: 103 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 97 (of type Swift.UInt16)
stdout>>> actual: 99 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 99 (of type Swift.UInt16)
stdout>>> actual: 101 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 100 (of type Swift.UInt16)
stdout>>> actual: 102 (of type Swift.UInt16)
stdout>>> check failed at ...swift/test/1_stdlib/subString.swift, line 16
stdout>>> expected: 101 (of type Swift.UInt16)
stdout>>> actual: 103 (of type Swift.UInt16)
[    XFAIL ] SubstringTests.UTF16View
[ RUN      ] SubstringTests.UTF8View
[       OK ] SubstringTests.UTF8View
SubstringTests: All tests passed

#### Resolved bug number: n/a

Before merging this pull request to apple/swift repository:

Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform	Comment
All supported platforms	@swift-ci Please smoke test
OS X platform	@swift-ci Please smoke test OS X platform
Linux platform	@swift-ci Please smoke test Linux platform

Validation Testing

Platform	Comment
All supported platforms	@swift-ci Please test
OS X platform	@swift-ci Please test OS X platform
Linux platform	@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

gribozavr · 2016-05-02T17:46:23Z

test/1_stdlib/subString.swift

+  expectEqual(x[i], y[i])
+}
+
+let s = "abcdefg"


Could you move this variable into each test that uses it? This would make tests standalone.

gribozavr · 2016-05-02T17:47:11Z

Thanks @natecook1000!

gribozavr · 2016-05-02T17:50:20Z

test/1_stdlib/subString.swift

+  expectEqual(String(t), "Cdefg")
+  expectEqual(s, "abcdefg")
+
+  checkMatch(s.characters, t, u.startIndex)


I don't think this is a valid assertion. t has been mutated before the position referenced by u.startIndex

Good point—I'll change it so it only tests string equality after a mutation. The mutations are there to ensure value semantics post-fix; those all pass today.

Checking that indices are interchangeable after mutation is a valid thing to do, we just need to mutate the tail part of the string that occurs after the index position.

gribozavr · 2016-05-02T17:50:42Z

test/1_stdlib/subString.swift

+  expectEqual(String(t), "Cdefg")
+  expectEqual(s, "abcdefg")
+
+  checkMatch(s.unicodeScalars, t, u.startIndex)


Same as above?

Both groups should be fixed now.

gribozavr · 2016-05-02T18:05:47Z

@swift-ci Please test and merge

natecook1000 · 2016-05-05T02:25:18Z

@swift-ci Please test and merge

tkremenek · 2016-05-05T06:19:14Z

@swift-ci test

gribozavr · 2016-05-05T08:26:56Z

CI issues are unrelated.

Enable stdlib thin CMO

Expanded string slicing test

5b24b19

gribozavr reviewed May 2, 2016
View reviewed changes

Make string slicing tests standalone

fd82698

gribozavr reviewed May 2, 2016
View reviewed changes

Move mutations after all index tests

5f7a01a

gribozavr merged commit e4614ee into swiftlang:master May 5, 2016

natecook1000 deleted the nc-string-test branch January 5, 2017 06:46

MaxDesiatov pushed a commit that referenced this pull request Apr 19, 2021

Merge pull request #2367 from swiftwasm/katei/embed-swms

9db63b9

Enable stdlib thin CMO

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[stdlib] Expanded string slicing test #2367

[stdlib] Expanded string slicing test #2367

natecook1000 commented May 2, 2016

Uh oh!

gribozavr May 2, 2016

Uh oh!

gribozavr commented May 2, 2016

Uh oh!

gribozavr May 2, 2016

Uh oh!

natecook1000 May 2, 2016

Uh oh!

gribozavr May 2, 2016 •

edited

Loading

Uh oh!

gribozavr May 2, 2016

Uh oh!

natecook1000 May 2, 2016

Uh oh!

gribozavr commented May 2, 2016

Uh oh!

natecook1000 commented May 5, 2016

Uh oh!

tkremenek commented May 5, 2016

Uh oh!

gribozavr commented May 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[stdlib] Expanded string slicing test #2367

[stdlib] Expanded string slicing test #2367

Conversation

natecook1000 commented May 2, 2016

What's in this pull request?

Uh oh!

gribozavr May 2, 2016

Choose a reason for hiding this comment

Uh oh!

gribozavr commented May 2, 2016

Uh oh!

gribozavr May 2, 2016

Choose a reason for hiding this comment

Uh oh!

natecook1000 May 2, 2016

Choose a reason for hiding this comment

Uh oh!

gribozavr May 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gribozavr May 2, 2016

Choose a reason for hiding this comment

Uh oh!

natecook1000 May 2, 2016

Choose a reason for hiding this comment

Uh oh!

gribozavr commented May 2, 2016

Uh oh!

natecook1000 commented May 5, 2016

Uh oh!

tkremenek commented May 5, 2016

Uh oh!

gribozavr commented May 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gribozavr May 2, 2016 •

edited

Loading