[stdlib] SE-0061: Add Generic Result and Error Handling to autoreleas… #2384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epool() Added `rethrows` and generic return type to ObjectiveC.autoreleasepool. Added tests of these new capabilities. Fixes SR-1394 and SR-842
Contributor
|
LGTM for functionality. @gribozavr or @dabrahams can you review for style? |
Member
|
@swift-ci test |
| // Using an @objc class to check that errors are retained across the pool | ||
| // boundaries. A classic crash is an error created inside a pool and then | ||
| // zombied before handling it outside the pool. | ||
| @objc class Error: NSObject, ErrorProtocol { |
Contributor
There was a problem hiding this comment.
Please add a space before the colon.
Member
|
@swift-ci test and merge |
Contributor
Author
|
It looks like the Linux build failed for unrelated reasons, if I'm understanding the listed results correctly. |
Member
|
Indeed. Re-testing. |
Member
|
@swift-ci test linux |
Member
|
@swift-ci please smoke test OS X platform |
lmihalkovic
pushed a commit
to lmihalkovic/swift
that referenced
this pull request
May 29, 2016
swiftlang#2384) * [stdlib] SE-0061: Add Generic Result and Error Handling to autoreleasepool() Added `rethrows` and generic return type to ObjectiveC.autoreleasepool. Added tests of these new capabilities. Fixes SR-1394 and SR-842 * Updated for code style review.
MaxDesiatov
added a commit
that referenced
this pull request
Apr 19, 2021
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
rethrowsand generic return type toObjectiveC.autoreleasepool.Added tests of these new capabilities.
Fixes #43454