[TF] Make whole-tensor reductions safe for tracing #24009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently global reductions like `sum` try to access the `rank` property, which is dynamically unavailable on abstractified tensors. Switch to a `reshape` then single-axis reduction.
dan-zheng
approved these changes
Apr 13, 2019
Contributor
|
@swift-ci Please test tensorflow |
rxwei
reviewed
Apr 13, 2019
Author
|
Looks like CI is down, but I'm merging because I'd like to have this in the build tomorrow. |
rxwei
added a commit
that referenced
this pull request
Apr 15, 2019
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
…#24009)" (swiftlang#24038) This reverts commit 71cd119.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently global reductions like
sumtry to access therankproperty, which is dynamically unavailable on abstractified tensors. Switch to areshapethen single-axis reduction.