Fix callable type-checking. #24103
Merged
Fix callable type-checking. #24103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove logic specific to nominal types in CSSimplify.cpp. This enables callable functionality on values with a generic type parameter type conforming to a protocol with a `call func` method.
|
This unblocks code like: func testLayer<L: Layer>(_ layer: L, _ input: L.Input) -> L.Output {
return layer(input)
} |
rxwei
approved these changes
Apr 17, 2019
|
@swift-ci please test tensorflow |
4 similar comments
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
CI seems dead on this PR. I've tested it locally. Merging since it's crunch time. |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
Remove logic specific to nominal types in CSSimplify.cpp. This enables callable functionality on values with a generic type parameter type conforming to a protocol with a `call func` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove logic specific to nominal types in CSSimplify.cpp.
This enables callable functionality on values with a generic type parameter
type conforming to a protocol with a
call funcmethod.