[AutoDiff] Add requirements to @differentiable attribute on getters.
#24115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test tensorflow |
Contributor
Author
|
Retriggering CI in an attempt to make CI prioritize #24116. |
Contributor
Author
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Apr 18, 2019
If a nominal type conditionally conforms to `Differentiable`, use the conditional conformance requirements in getter `@differentiable` attributes. Resolves TF-435.
Contributor
|
@swift-ci please test tensorflow |
5 similar comments
Contributor
|
@swift-ci please test tensorflow |
Contributor
|
@swift-ci please test tensorflow |
Contributor
|
@swift-ci please test tensorflow |
Contributor
|
@swift-ci please test tensorflow |
Contributor
|
@swift-ci please test tensorflow |
Contributor
|
@swift-ci please test tensorflow Linux |
4 similar comments
Contributor
|
@swift-ci please test tensorflow Linux |
Contributor
|
@swift-ci please test tensorflow Linux |
Contributor
|
@swift-ci please test tensorflow Linux |
Contributor
|
@swift-ci please test tensorflow Linux |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
May 11, 2019
swiftlang#24115) If a nominal type conditionally conforms to `Differentiable`, use the conditional conformance requirements in getter `@differentiable` attributes. Resolves TF-435.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a nominal type conditionally conforms to
Differentiable, use theconditional conformance requirements in getter
@differentiableattributes.Resolves TF-435.