Skip to content

[5.1] [IRGen] Emit lazy opaque type descriptors. #24338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DougGregor merged 1 commit into from
Apr 29, 2019
Merged

[5.1] [IRGen] Emit lazy opaque type descriptors. #24338

DougGregor merged 1 commit into from
Apr 29, 2019

Conversation

@DougGregor
Copy link
Member

@DougGregor DougGregor commented Apr 27, 2019

These were recorded but never emitted. Fixes rdar://problem/50258536.

@DougGregor
Copy link
Member Author

DougGregor commented Apr 27, 2019

@swift-ci please test and merge

@DougGregor
[IRGen] Emit lazy opaque type descriptors.
894703d 
These were recorded but never emitted. Fixes rdar://problem/50258536.
@DougGregor DougGregor force-pushed the irgen-emit-lazy-opaque-descriptors-5.1 branch from 3f94a41 to 894703d Compare April 27, 2019 16:53
@DougGregor
Copy link
Member Author

DougGregor commented Apr 27, 2019

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

DougGregor commented Apr 27, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 27, 2019

Build failed
Swift Test Linux Platform
Git Sha - 894703d

@DougGregor
Copy link
Member Author

DougGregor commented Apr 27, 2019

It looks like we have a Clang-related problem:

10:56:21 Failing Tests (29):
10:56:21     Swift(linux-x86_64) :: Serialization/xref-nested-clang-type.swift
10:56:21     Swift(linux-x86_64) :: SILGen/objc_bridged_block_optionality_diff.swift
10:56:21     Swift(linux-x86_64) :: SILGen/objc_bridged_generic_conformance.swift
10:56:21     Swift(linux-x86_64) :: SILGen/lying_about_optional_return_objc.swift
10:56:21     Swift(linux-x86_64) :: IRGen/related_entity.sil
10:56:21     Swift(linux-x86_64) :: IRGen/objc_properties_jit.swift
10:56:21     Swift(linux-x86_64) :: IRGen/objc_generic_protocol_conformance.swift
10:56:21     Swift(linux-x86_64) :: IRGen/objc_properties_imported.swift
10:56:21     Swift(linux-x86_64) :: IRGen/objc_int_encoding.sil
10:56:21     Swift(linux-x86_64) :: IRGen/objc_bridged_generic_conformance.swift
10:56:21     Swift(linux-x86_64) :: IRGen/objc_factory_method.sil
10:56:21     Swift(linux-x86_64) :: IRGen/class_resilience_objc.swift
10:56:21     Swift(linux-x86_64) :: Frontend/dependencies.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/objc_parse_verifier.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/objc_diags.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/ctypes_parse_objc.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/bad-ns-extensible-string-enum.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/no-import-objc.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/enum-error-redeclared.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/enum-dataflow.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/import-as-member-objc.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/nullability.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/attr-objc_subclassing_restricted.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/MixedSource/mixed-target-using-header.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/MixedSource/Xcc_include.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/MixedSource/resolve-cross-language.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/MixedSource/import-mixed-with-header-twice.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/MixedSource/mixed-target-using-header-swift4.swift
10:56:21     Swift(linux-x86_64) :: ClangImporter/MixedSource/mixed-target-using-module.swift

@DougGregor
Copy link
Member Author

DougGregor commented Apr 29, 2019

@swift-ci please test Linux

@swift-ci
Copy link
Contributor

swift-ci commented Apr 29, 2019

Build failed
Swift Test Linux Platform
Git Sha - 894703d

jckarter
jckarter approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻‍♂️ Thanks!

@DougGregor
Copy link
Member Author

DougGregor commented Apr 29, 2019

@swift-ci please test Linux

@DougGregor DougGregor merged commit 19ffbdd into swiftlang:swift-5.1-branch Apr 29, 2019
@DougGregor DougGregor deleted the irgen-emit-lazy-opaque-descriptors-5.1 branch April 29, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jckarter jckarter jckarter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DougGregor @swift-ci @jckarter